feat(loops): Make builder sessions resumable from the loops page#3745
Conversation
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
|
😎 This pull request was merged. |
|
✅ Visual changes approved by @charlesvien — baseline updated in 2 changed. |
![veria-ai[bot]](https://avatars.githubusercontent.com/in/1723776?s=60&v=4){kind=small}
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
|
Reviews (1): Last reviewed commit: "make loop builder sessions resumable" | Re-trigger Greptile |
2 updated Run: f8911d32-bff0-4dcb-bef3-5575a0094281 Co-authored-by: charlesvien <5378415+charlesvien@users.noreply.github.com>
charlesvien
added
the
Stamphog
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Contained UI feature (resumable loop-builder sessions) with real test coverage; the one substantive review concern (cross-account prompt persistence) is verifiably fixed in the diff via identity-scoped storage and a version migration that drops unattributed legacy entries, corroborated by a bot follow-up comment. No risky-territory surface (auth, billing, migrations, CI, deps) is touched.
- Author wrote 67% of the modified lines and has 155 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 347L, 8F substantive, 538L/10F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (538L, 10F, two-areas, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 0092213 · reviewed head d583d63 |
2 updated Run: 78b2e825-5647-4b0d-ae22-53a298a35783 Co-authored-by: charlesvien <5378415+charlesvien@users.noreply.github.com>
New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.
There was a problem hiding this comment.
Contained UI feature (loop builder resumability) with no auth/billing/crypto/API/dependency/CI/migration surface touched; the one substantive security concern (cross-account prompt leakage) was verifiably fixed in the diff via per-identity scoping and a version-bump migration that drops unattributed entries, and an agent reviewer confirmed no open concerns remain.
- Author wrote 67% of the modified lines and has 155 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 347L, 8F substantive, 538L/10F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (538L, 10F, two-areas, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 0092213 · reviewed head 035e9f5 |
New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.
There was a problem hiding this comment.
Contained client-side UI/feature work (loop builder session tracking) with no touch on auth, billing, migrations, dependencies, or CI; the one security concern a bot reviewer raised (cross-account prompt leakage) is verifiably fixed in the diff via per-identity scoping and a store migration that drops unattributed entries, and it's covered by new unit tests.
- Author wrote 80% of the modified lines and has 155 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 347L, 9F substantive, 538L/11F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (538L, 11F, two-areas, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 0092213 · reviewed head a8ff0f7 |
New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.
There was a problem hiding this comment.
Local-only UI feature (builder session resumability on the loops page) with no changes to APIs, data models, auth flows, billing, or dependencies; the one flagged privacy concern (persisted sessions leaking across accounts) is visibly fixed in this diff via per-identity scoping and a store version bump that drops unattributed legacy entries, and new unit tests cover the store and liveness logic.
- Author wrote 21% of the modified lines and has 169 merged PRs in these paths (familiarity MODERATE).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 381L, 16F substantive, 572L/18F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (572L, 18F, two-areas, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 0092213 · reviewed head 1d5c806 |
1 participant
Problem
Starting the loop builder from the loops page creates an anonymous repo-less cloud task and navigates to it. Leaving that task (clicking another task, going back to Loops) left no way back: the loops page had no memory of the session and the sidebar row was titled with the raw prompt, indistinguishable from any other task.
Changes
stopCloudRunpath as the task view's "Stop run" button, then removes the row.useInboxCloudTaskRunnergained anonTaskCreatedcallback so variants can observe the created task.How did you test this?
pnpm --filter @posthog/ui typecheckand Biome on the touched files.Automatic notifications